Merged
Conversation
Owner
Author
is this something that would help to improve alignment of certain (anti-)patterns? |
Pankraz76
commented
Jul 13, 2025
pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/performance/stringtostring/User.java
Show resolved
Hide resolved
Pankraz76
commented
Jul 13, 2025
|
|
||
| package net.sourceforge.pmd.lang.typescript.ast; | ||
|
|
||
| import org.antlr.v4.runtime.*; |
Owner
Author
There was a problem hiding this comment.
this wildcard it nice to see gone, is the unused import now resolving these, or what recipe did it?
# Conflicts: # pom.xml
Pankraz76
commented
Jul 13, 2025
pmd-java/src/test/java/net/sourceforge/pmd/lang/java/symbols/internal/TypeAnnotTestUtil.java
Show resolved
Hide resolved
Pankraz76
commented
Jul 13, 2025
|
|
||
| package net.sourceforge.pmd.lang.java.ast; | ||
|
|
||
| import net.sourceforge.pmd.lang.ast.Node; |
Owner
Author
There was a problem hiding this comment.
Owner
Author
|
item making usefull but unknown changes: |
Owner
Author
|
again strange changes on CI only: |
|
@Pankraz76 This rule already exists: https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#literalsfirstincomparisons |
Owner
Author
|
yes im sorry, thanks for checkup. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)